Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add button to show public IPs associated with vlanid #8717

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

vishesh92
Copy link
Member

Description

This PR fixes #8080 by allowing user to list down public IPs by physical network or per vlanid.

Adds "View Public IP Addresses" button for physical network
image

Adds "View Public IP Addresses" button for vlan IP ranges
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8717 (QA-JID-290)

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (4e34e6b) to head (6bab2a3).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.18    #8717   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
  Complexity     9203     9203           
=========================================
  Files          2724     2724           
  Lines        258130   258130           
  Branches      40232    40232           
=========================================
  Hits          33989    33989           
  Misses       219833   219833           
  Partials       4308     4308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

verified on qacloud

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland linked an issue Feb 28, 2024 that may be closed by this pull request
@DaanHoogland DaanHoogland merged commit 52d5b27 into apache:4.18 Feb 28, 2024
26 checks passed
@DaanHoogland DaanHoogland deleted the public-ips-by-phy-net branch February 28, 2024 10:34
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 5, 2024
@DaanHoogland DaanHoogland added this to the 4.18.2.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Vishesh's Rota List
Development

Successfully merging this pull request may close these issues.

IP range cannot be deleted, but no valid reason is known
4 participants