-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: update default value of setting 'expose.dns.externally' to 'false" #8776
server: update default value of setting 'expose.dns.externally' to 'false" #8776
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8776 +/- ##
=========================================
Coverage 13.16% 13.16%
Complexity 9205 9205
=========================================
Files 2724 2724
Lines 258149 258149
Branches 40235 40235
=========================================
Hits 33987 33987
Misses 219856 219856
Partials 4306 4306 ☔ View full report in Codecov by Sentry. |
@blueorangutan package |
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8914 |
@blueorangutan test |
@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
this is a critical issue |
[SF] Trillian test result (tid-9447)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM
Merging based on approvals and CI result |
Description
This PR fixes the issue that the DNS is exposed publicly by default.
related to:
6a72e6e
#1663
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?