Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: update default value of setting 'expose.dns.externally' to 'false" #8776

Merged

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes the issue that the DNS is exposed publicly by default.

related to:
6a72e6e
#1663

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (d487a1c) to head (47163bc).
Report is 1 commits behind head on 4.18.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.18    #8776   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
  Complexity     9205     9205           
=========================================
  Files          2724     2724           
  Lines        258149   258149           
  Branches      40235    40235           
=========================================
  Hits          33987    33987           
  Misses       219856   219856           
  Partials       4306     4306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8914

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

this is a critical issue
@rohityadavcloud @NuxRo @DaanHoogland @JoaoJandre

@blueorangutan
Copy link

[SF] Trillian test result (tid-9447)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42419 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8776-t9447-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@NuxRo NuxRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@JoaoJandre
Copy link
Contributor

Merging based on approvals and CI result

@JoaoJandre JoaoJandre merged commit 9d748f0 into apache:4.18 Mar 15, 2024
26 checks passed
@DaanHoogland DaanHoogland deleted the 4.18-expose.dns.externally-default-false branch March 15, 2024 14:24
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants