server: fix haproxy misconfiguration after VPC VR start #8881
Conversation
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9156 |
weizhouapache
force-pushed
the
4.18-fix-vpc-vr-haproxy-misconfiguration
branch
from
d99ce9c
to
e63cf69
Compare
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8881 +/- ##
============================================
- Coverage 13.17% 13.17% -0.01%
+ Complexity 9215 9214 -1
============================================
Files 2725 2725
Lines 258215 258235 +20
Branches 40247 40249 +2
============================================
- Hits 34017 34013 -4
- Misses 219885 219911 +26
+ Partials 4313 4311 -2 ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9157 |
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Hey @weizhouapache, is this PR already done to be reviewed? |
|
[SF] Trillian Build Failed (tid-9704) |
@SadiJr |
|
@blueorangutan test rocky8 kvm-rocky8 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-9707) |
|
[SF] Trillian Build Failed (tid-9713) |
|
[SF] Trillian test result (tid-9714)
|
|
@blueorangutan test alma9 kvm-alma9 |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests |
| final List<LoadBalancingRule> lbRules = new ArrayList<>(); | ||
| createLoadBalancingRulesList(lbRules, lbs); | ||
| s_logger.debug("Found " + lbRules.size() + " load balancing rule(s) to apply as a part of VPC VR " + domainRouterVO + " start."); | ||
| if (!lbRules.isEmpty()) { |
There was a problem hiding this comment.
| if (!lbRules.isEmpty()) { | |
| if (lbRules.isEmpty()) { | |
| return; | |
| } |
There was a problem hiding this comment.
@sureshanaparti I don't think this return mid-method makes for better readable code.
There was a problem hiding this comment.
CLGTM, tested manually:
- Created a VPC with two tiers (
test1andtest2); - Created a VM for each one of this tiers;
- Acquired one public IP for each one of this tiers;
- Created load balancer rules in each public IP for each VM
- Applied restart with clean-up in the VPC
The LB rules were created correctly and only one command was sent for it.
|
Merging based on approvals and manual testing. |
|
[SF] Trillian test result (tid-9724)
|
Description
This PR fixes #8745
/etc/haproxy/haproxy.cfgcontains the load balancer configuration of both 2 tiers./etc/haproxy/haproxy.cfgin new vpc vr should be same as before (step 3)/etc/haproxy/haproxy.cfgin new vpc vr contains the load balancer configuration for only 1 tier.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?