Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup 4.19 build issue #8905

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fixup 4.19 build issue #8905

merged 1 commit into from
Apr 12, 2024

Conversation

vishesh92
Copy link
Member

Description

This PR fixes the build issue on 4.19

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 changed the title Fixup main build issue Fixup 4.19 build issue Apr 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.54%. Comparing base (c7626eb) to head (30bb2ee).
Report is 4 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8905      +/-   ##
============================================
+ Coverage     15.36%   16.54%   +1.18%     
- Complexity    13620    14825    +1205     
============================================
  Files          4862     4863       +1     
  Lines        325934   326034     +100     
  Branches      45814    45840      +26     
============================================
+ Hits          50074    53951    +3877     
+ Misses       268857   264377    -4480     
- Partials       7003     7706     +703     
Flag Coverage Δ
simulator-marvin-tests 16.54% <ø> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Member

strange issue caused by same method in #8872 and #8800

@weizhouapache weizhouapache merged commit 44aa08c into apache:4.19 Apr 12, 2024
9 of 24 checks passed
@DaanHoogland DaanHoogland deleted the fixup-main branch April 12, 2024 14:38
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@DaanHoogland DaanHoogland added this to the 4.19.1.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants