Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to previous timestamp on logging #8925

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoaoJandre
Copy link
Contributor

Description

Before #7131, the logs' timestamp was in the 2024-04-02 22:04:28,617, with the upgrade to log4j2, the logs' timestamp was changed to the 2024-04-02T21:55:12,724 format. This PR changes the timestamp back to the previous format.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@JoaoJandre
Copy link
Contributor Author

JoaoJandre commented Apr 16, 2024

The PR is ready for review, I just need to test it manually on all components, until then I'll keep it on draft.

@DaanHoogland
Copy link
Contributor

Is this really needed @JoaoJandre ? seems to me this is a user choice and taking a standard as the default is not that bad a choice. (did you get complaints?)

@JoaoJandre
Copy link
Contributor Author

Is this really needed @JoaoJandre ? seems to me this is a user choice and taking a standard as the default is not that bad a choice. (did you get complaints?)

This will revert the default timestamp to what it used to be before the Log4j2 update, I mistakenly changed the default timestamp when upgrading the default log4j configurations on #7131. This PR will change the timestamp to the one that was being used before #7131.

The change on the timestamp pattern could break users' log parsers, that's why I created this PR. If they wish, they can change the value to ISO8601 or whatever they prefer.

@JoaoJandre JoaoJandre marked this pull request as ready for review May 16, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants