-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password enabled during ISO register and update #8992
Add password enabled during ISO register and update #8992
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8992 +/- ##
=============================================
+ Coverage 13.17% 15.28% +2.11%
- Complexity 9214 11520 +2306
=============================================
Files 2725 5425 +2700
Lines 258235 474008 +215773
Branches 40249 57932 +17683
=============================================
+ Hits 34013 72447 +38434
- Misses 219913 393518 +173605
- Partials 4309 8043 +3734
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - did n't check/test the backend, but seems good to me
@GaOrtiga , should the flag also be added to the UI/output? (or do we create an issue and merge as is?) |
@DaanHoogland Good catch, thanks. Since this is a simple addition, I will add it to this PR. |
@DaanHoogland I have commited the requested changes |
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
tested ok, updating a ISO and leaving the view to return shows the right value which means the backend stored it. |
Co-authored-by: Gabriel <gabriel.fernandes@scclouds.com.br>
Description
The parameter
passwordenabled
is available on the APIs that register and update ISOs, however, it had not been added to the UI yet.This parameter was added to the UI, making it possible to specify it when registering/updating ISOs.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Before
After
How Has This Been Tested?