Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password enabled during ISO register and update #8992

Merged

Conversation

GaOrtiga
Copy link
Contributor

Description

The parameter passwordenabled is available on the APIs that register and update ISOs, however, it had not been added to the UI yet.

This parameter was added to the UI, making it possible to specify it when registering/updating ISOs.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Before

image

image

After

image

image

How Has This Been Tested?

@GaOrtiga GaOrtiga changed the title add password enabled during ISO register and update Add password enabled during ISO register and update Apr 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.28%. Comparing base (a5508ac) to head (b1ffac1).
Report is 652 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #8992       +/-   ##
=============================================
+ Coverage     13.17%   15.28%    +2.11%     
- Complexity     9214    11520     +2306     
=============================================
  Files          2725     5425     +2700     
  Lines        258235   474008   +215773     
  Branches      40249    57932    +17683     
=============================================
+ Hits          34013    72447    +38434     
- Misses       219913   393518   +173605     
- Partials       4309     8043     +3734     
Flag Coverage Δ
uitests 4.26% <ø> (?)
unittests 16.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm +
image
however
image
... no indication it is password enabled in the details list.

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did n't check/test the backend, but seems good to me

@DaanHoogland
Copy link
Contributor

@GaOrtiga , should the flag also be added to the UI/output? (or do we create an issue and merge as is?)

@GaOrtiga
Copy link
Contributor Author

@GaOrtiga , should the flag also be added to the UI/output? (or do we create an issue and merge as is?)

@DaanHoogland Good catch, thanks. Since this is a simple addition, I will add it to this PR.

@GaOrtiga
Copy link
Contributor Author

GaOrtiga commented May 1, 2024

@DaanHoogland I have commited the requested changes

image

@apache apache deleted a comment from blueorangutan May 1, 2024
@apache apache deleted a comment from blueorangutan May 1, 2024
@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8992 (QA-JID-332)

@DaanHoogland
Copy link
Contributor

tested ok, updating a ISO and leaving the view to return shows the right value which means the backend stored it.

@DaanHoogland DaanHoogland merged commit ab8197c into apache:main May 2, 2024
22 of 24 checks passed
@rohityadavcloud rohityadavcloud added this to the 4.20.0.0 milestone May 2, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
Co-authored-by: Gabriel <gabriel.fernandes@scclouds.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants