Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove test/src-not-used/ #9007

Merged
merged 1 commit into from May 8, 2024

Conversation

weizhouapache
Copy link
Member

Description

This PR removes unused project: test/src-not-used/

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9484

@rohityadavcloud
Copy link
Member

LGTM - smoketests aren't required if this was dead/unused code to begin with.

@DaanHoogland
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@DaanHoogland
Copy link
Contributor

LGTM - smoketests aren't required if this was dead/unused code to begin with.

right, didn't check that (or the PR number) I stopped the jobs and we should be fine to merge.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.24%. Comparing base (9d5d4e5) to head (78ee605).
Report is 1 commits behind head on 4.18.

Additional details and impacted files
@@            Coverage Diff             @@
##               4.18    #9007    +/-   ##
==========================================
  Coverage     12.24%   12.24%            
- Complexity     9291     9292     +1     
==========================================
  Files          4698     4698            
  Lines        414259   414259            
  Branches      51377    50710   -667     
==========================================
+ Hits          50707    50716     +9     
+ Misses       357251   357241    -10     
- Partials       6301     6302     +1     
Flag Coverage Δ
unittests 12.24% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-10171)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41717 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9007-t10171-kvm-centos7.zip
Smoke tests completed. 108 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_create_pvlan_network Error 0.07 test_pvlan.py
test_01_vpc_site2site_vpn Failure 282.99 test_vpc_vpn.py

@weizhouapache
Copy link
Member Author

@blueorangutan test matrix

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-10185)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45729 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9007-t10185-xenserver-71.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_create_pvlan_network Error 0.08 test_pvlan.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-10187)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46180 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9007-t10187-kvm-centos7.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_migrate_vm Error 48.12 test_vm_life_cycle.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-10186)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51582 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9007-t10186-vmware-67u3.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache
Copy link
Member Author

weizhouapache commented May 8, 2024

the test failures are not related to this pr

marvin.cloudstackException.CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:The VLAN tag to use for new guest network, 2468 is already being used for dynamic vlan allocation for the guest network in zone pr9007-t10185-xenserver-71

and
Exception: Job failed: {accountid : '00dc36b4-0cb2-11ef-b0f4-1e00f60001d2', userid : '00dd8de2-0cb2-11ef-b0f4-1e00f60001d2', cmd : 'org.apache.cloudstack.api.command.admin.vm.MigrateVMCmd', jobstatus : 2, jobprocstatus : 0, jobresultcode : 431, jobresulttype : 'object', jobresult : {errorcode : 431, errortext : 'Cannot migrate VM, destination host is not in correct state, has status: Connecting, state: Enabled'}, jobinstancetype : 'VirtualMachine', jobinstanceid : 'aa2151a3-6879-4951-81ee-af6892ecbd5f', created : '2024-05-08T06:27:17+0000', completed : '2024-05-08T06:27:17+0000', jobid : '56824238-11a0-4adb-a089-76d8886476d9'}

@weizhouapache weizhouapache merged commit 7a34194 into apache:4.18 May 8, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants