Testcases Added

[my-code-AL]

Description

This PR adds a new tester directory and file at core/src/test/java/com/cloud/serializer/GsonHelperTest.java. Previously, the serializer directory did not exist. The new test file checks the base functionality of GSON conversion into JSON of a Java CloudStack object implementing the dataStoreTo interface to ensure it works properly with a CloudStack class.

Additionally, this PR includes a test for OVAProcessor.java that tests the OVA processing of large objects and adds a test for PasswordPolicyImpl.java at server/src/test/java/com/cloud/user/PasswordPolicyImplTest.java. The new test verifies that a password meets all test case points (such as length, minimum special characters, minimum uppercase characters, regex specifications) instead of just individual criteria.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• [] Bug fix (non-breaking change which fixes an issue)
• [] Enhancement (improves an existing feature and functionality)
• [X ] Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

The tests were designed to cover various edge cases and typical usage scenarios to ensure robustness. For GsonHelperTest.java, different CloudStack objects were serialized and deserialized to verify GSON conversion accuracy. For OVAProcessor.java, large file sizes were used to test the OVA processing logic. For PasswordPolicyImpl.java, various password inputs were tested to ensure they meet all specified criteria.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions.
  Apache CloudStack is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
  Slack: https://apachecloudstack.slack.com/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.28%. Comparing base (f1c3d2c) to head (93378f4).
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##              main    #9116       +/-   ##
============================================
+ Coverage     4.25%   15.28%   +11.02%     
- Complexity       0    11537    +11537     
============================================
  Files          363     5424     +5061     
  Lines        29686   474334   +444648     
  Branches      5214    58626    +53412     
============================================
+ Hits          1264    72509    +71245     
- Misses       28279   393767   +365488     
- Partials       143     8058     +7915     

Flag	Coverage Δ
uitests	4.25% <ø> (-0.01%)	⬇️
unittests	16.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[vishesh92]

@my-code-AL Build is failing with error:

Error:  /home/runner/work/cloudstack/cloudstack/core/src/test/java/com/cloud/storage/template/OVAProcessorTest.java:134: Line has trailing spaces. [RegexpSingleline]
Error:  /home/runner/work/cloudstack/cloudstack/core/src/test/java/com/cloud/serializer/GsonHelperTest.java:75: Line has trailing spaces. [RegexpSingleline]

[blueorangutan]

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9718

[my-code-AL]

@DaanHoogland Howdy Daan, I was able to update the checkstyle ruleset for these test cases. Let me know if there is anything else I can do!

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

clgtm

[DaanHoogland]

actually this is just unit-tests, so no packaging needed to prove this, as GHA does already run those.
alright by you like this @weizhouapache ?

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9778