Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated install-non-oss with vmware v7.0 and v8.0 #9205

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

oferchen
Copy link

@oferchen oferchen commented Jun 10, 2024

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@oferchen oferchen mentioned this pull request Jun 10, 2024
@weizhouapache
Copy link
Member

thanks for the pr @oferchen
actually more packages are needed
see https://github.com/shapeblue/cloudstack-nonoss/blob/main/install-non-oss.sh

@oferchen
Copy link
Author

oferchen commented Jun 10, 2024

thanks for the pr @oferchen actually more packages are needed see https://github.com/shapeblue/cloudstack-nonoss/blob/main/install-non-ossI also added vsphere and customer connect and Netapp and the two juniper sdks

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.32%. Comparing base (3a0c312) to head (b9dc3a4).

Current head b9dc3a4 differs from pull request most recent head f0eb682

Please upload reports for the commit f0eb682 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9205      +/-   ##
============================================
- Coverage     15.42%   15.32%   -0.11%     
+ Complexity    11818    11654     -164     
============================================
  Files          5474     5452      -22     
  Lines        478602   476525    -2077     
  Branches      62097    60180    -1917     
============================================
- Hits          73823    73016     -807     
+ Misses       396649   395440    -1209     
+ Partials       8130     8069      -61     
Flag Coverage Δ
uitests 4.20% <ø> (+0.02%) ⬆️
unittests 16.07% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohityadavcloud
Copy link
Member

cc @nvazquez @Pearl1594
@oferchen I think what @weizhouapache is more appropriate it’s because most of us or our CI automation don’t use this script anymore.

@oferchen
Copy link
Author

oferchen commented Jun 11, 2024

cc @nvazquez @Pearl1594 @oferchen I think what @weizhouapache is more appropriate it’s because most of us or our CI automation don’t use this script anymore.

As long as it is included in the repository might as well be updated and functional, specifically because some of the functionality won't work without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants