ui: fix minor issue with webhook forms #9335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix width of Test webhook delivery form - Fix auto execution of test delivery in create webhook form Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
UI on QA may not work as it is not based on main and APIs from the backend won't be available but still... |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9335 +/- ##
============================================
+ Coverage 15.42% 15.51% +0.09%
- Complexity 11818 11938 +120
============================================
Files 5474 5492 +18
Lines 478602 480617 +2015
Branches 62097 59689 -2408
============================================
+ Hits 73823 74574 +751
- Misses 396649 397790 +1141
- Partials 8130 8253 +123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
rohityadavcloud
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
Form width is too much
Form is not executing test webhook delivery automatically when one of the earlier used value is selected
https://github.com/apache/cloudstack/assets/153340/a9fc0a83-1fad-434c-97a3-8034a3768519
After
Form width fixed
Form is now executing test webhook delivery automatically when one of the earlier used value is selected
https://github.com/apache/cloudstack/assets/153340/1904a5cf-54de-463b-8763-562a435ce784
How Has This Been Tested?
How did you try to break this feature and the system with this change?