The BlockContext wasn't pushed at the BlockCallStack when doing a pol…

…ymorphic call through the block protocol (e.g. block:/foo), this made subsequent block protocol call be called relative to the wrong context. This hopefully fixes the problem reported in JIRA issue COCOON-1939. git-svn-id: https://svn.apache.org/repos/asf/cocoon/trunk/core/cocoon-blocks-fw@468664 13f79535-47bb-0310-9956-ffa450edef68
apache · Oct 28, 2006 · 842e096 · 842e096
1 parent 3c36e08
commit 842e096
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockContext.java b/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockContext.java
@@ -433,7 +433,12 @@ private boolean exists() {
          */
         public void forward(ServletRequest request, ServletResponse response)
         throws ServletException, IOException {
-            BlockContext.this.servlet.service(request, response);
+            try {
+                BlockCallStack.enterBlock(BlockContext.this);
+                BlockContext.this.servlet.service(request, response);
+            } finally {
+                BlockCallStack.leaveBlock();
+            }
         }
 
         /* (non-Javadoc)

diff --git a/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockServlet.java b/cocoon-blocks-fw-impl/src/main/java/org/apache/cocoon/blocks/BlockServlet.java
@@ -120,12 +120,7 @@ protected void service(HttpServletRequest request, HttpServletResponse response)
     throws ServletException, IOException {
         RequestDispatcher dispatcher =
             this.blockContext.getRequestDispatcher(request.getPathInfo());
-        try {
-            BlockCallStack.enterBlock(this.blockContext);
-            dispatcher.forward(request, response);
-        } finally {
-            BlockCallStack.leaveBlock();
-        }
+        dispatcher.forward(request, response);
     }
 
     /**