Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix travis-ci scripts #24

Closed
wants to merge 4 commits into from
Closed

fix travis-ci scripts #24

wants to merge 4 commits into from

Conversation

XenoAmess
Copy link
Contributor

No description provided.

@XenoAmess
Copy link
Contributor Author

XenoAmess commented May 26, 2020 •
edited

test Jira347TestCase fails on jdk13, not everytime, but sometimes.

see https://travis-ci.org/github/apache/commons-beanutils/jobs/691171736#L436

opened as BEANUTILS-534

test MemoryLeakTestCase fails on jdk14, not everytime, but sometimes.

see https://travis-ci.org/github/apache/commons-beanutils/jobs/691178873#L650

opened as BEANUTILS-535

I just moved jdk13 and jdk14 to allow failure.
Once you fixed them, you can remove it from allow failure.

@melloware
Copy link
Contributor

Wouldn't it be better to help fix the tests rather than temporarily ignore failures?

@garydgregory
Copy link
Member

Wouldn't it be better to help fix the tests rather than temporarily ignore failures?

+1

Or at least understand and document the failure, possibly disabling the test under certain condition with a JUnit Assume call.

@XenoAmess
Copy link
Contributor Author

XenoAmess commented May 26, 2020 •
edited

Wouldn't it be better to help fix the tests rather than temporarily ignore failures?

  1. yes it is.
  2. I have no ideas about how to fix these bugs.
  3. I do think the bugs I found be minor problems, as this repo can work for such a long time without handling(or even noticing) the bug I mentioned.
  4. I assume there must be somebody who knows more than me about how to solve these bugs, for example some guys who knows more about this repo/this test class.
  5. this pr is not aimed to fix problems in your repo.
    this pr aims to fix the travis-ci scripts, and make the color besides each commit/pr only be red when new bugs comes, and otherwise always green.
    In doing so, you can find immediately when bugs (who fails unit tests) appears.
    In other words, this pr is a fix of "bugs in [the way to find a bug]", but not "fix a bug".
  6. it is "temporarily ignore failures" in this pr, but IMO this "temporarily ignore failures" is not started by this pr, but by when the first time travis-ci changed from green to red in this repo, and nobody track/fixed it.

@melloware
Copy link
Contributor

@XenoAmess You can kill this PR we have the build working properly now on JDK15+

@garydgregory
Copy link
Member

Close per previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@XenoAmess @melloware @garydgregory