CLI-313: adding new test to properly handling negative case of invali… #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
reviewed
Mar 7, 2022
| @@ -580,7 +580,7 @@ private boolean isArgument(final String token) { | |||
| * Tests if the specified token is a Java-like property (-Dkey=value). | |||
| */ | |||
| private boolean isJavaProperty(final String token) { | |||
| final String opt = token.substring(0, 1); | |||
| final String opt = token.length() > 0? token.substring(0, 1): null; | |||
There was a problem hiding this comment.
Use String#isEmpty and flip the ternary. A space is missing around the "?". Add a test.
There was a problem hiding this comment.
Ping?
I'm starting to resume the work as I've been not feeling well.
garydgregory
requested changes
Aug 13, 2023
| @@ -18,9 +18,11 @@ Licensed to the Apache Software Foundation (ASF) under one or more | |||
| package org.apache.commons.cli; | |||
|
|
|||
| import static org.junit.Assert.assertEquals; | |||
| import static org.junit.Assert.assertThrows; | |||
There was a problem hiding this comment.
These imports are added but not used?
| @@ -580,7 +580,7 @@ private boolean isArgument(final String token) { | |||
| * Tests if the specified token is a Java-like property (-Dkey=value). | |||
| */ | |||
| private boolean isJavaProperty(final String token) { | |||
| final String opt = token.substring(0, 1); | |||
| final String opt = token.length() > 0? token.substring(0, 1): null; | |||
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=========================================
Coverage ? 93.12%
Complexity ? 569
=========================================
Files ? 21
Lines ? 1207
Branches ? 215
=========================================
Hits ? 1124
Misses ? 46
Partials ? 37 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I think this is now superseeded by PR #186 and thus can be closed without merging. |
|
@hungklu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d argument input