Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix travis-ci scripts #48

Merged
merged 3 commits into from
Jul 24, 2020
Merged

fix travis-ci scripts #48

merged 3 commits into from
Jul 24, 2020

Conversation

XenoAmess
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented May 26, 2020

Coverage Status

Coverage increased (+0.1%) to 93.976% when pulling 17d0ecd on XenoAmess:patch-1 into 00c22c3 on apache:master.

Copy link
Contributor

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need both openjdk11 and oraclejdk11 ?

@XenoAmess
Copy link
Contributor Author

XenoAmess commented May 31, 2020

I wonder if we need both openjdk11 and oraclejdk11 ?

I thought there must be a reason to contain both in original travis-ci scripts, so I didn't remove any of them.

.travis.yml Outdated

- jdk: openjdk8
- jdk: openjdk11
- jdk: openjdk12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop:

openjdk12
openjdk13
oraclejdk11

Now Java 14 is out 12 and 13 are redundant. Testing on oraclejdk11 and openjdk11 also seems redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now Java 14 is out 12 and 13 are redundant. Testing on oraclejdk11 and openjdk11 also seems redundant.

we can drop 12 but 13 but I think we'd better remain 11, as 11 is LTS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point was that testing on both oraclejdk11 and openjdk11 seems redundant. I would also drop oraclejdk11 and just leave openjdk11.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point was that testing on both oraclejdk11 and openjdk11 seems redundant. I would also drop oraclejdk11 and just leave openjdk11.

@aherbert oh, got it:)

@aherbert aherbert merged commit fc3e676 into apache:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants