-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix travis-ci scripts #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we need both openjdk11 and oraclejdk11 ?
I thought there must be a reason to contain both in original travis-ci scripts, so I didn't remove any of them. |
.travis.yml
Outdated
|
||
- jdk: openjdk8 | ||
- jdk: openjdk11 | ||
- jdk: openjdk12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you drop:
openjdk12
openjdk13
oraclejdk11
Now Java 14 is out 12 and 13 are redundant. Testing on oraclejdk11 and openjdk11 also seems redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now Java 14 is out 12 and 13 are redundant. Testing on oraclejdk11 and openjdk11 also seems redundant.
we can drop 12 but 13 but I think we'd better remain 11, as 11 is LTS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point was that testing on both oraclejdk11 and openjdk11 seems redundant. I would also drop oraclejdk11 and just leave openjdk11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point was that testing on both oraclejdk11 and openjdk11 seems redundant. I would also drop oraclejdk11 and just leave openjdk11.
@aherbert oh, got it:)
No description provided.