Deprecate Closure in favor of java.util.function.Consumer

apache · Apr 28, 2024 · c176372 · c176372
1 parent b678b30
commit c176372
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -24,8 +24,9 @@
   <body>
   <release version="4.5.0" date="YYYY-MM-DD" description="This milestone release requires Java 8 and adds the package `org.apache.commons.collections4.bloomfilter`.">
      <!-- ADD -->
-     <action issue="COLLECTIONS-852" type="update" dev="ggregory" due-to="Claude Warren, Alex Herbert">Add layerd bloom filter clean method #476 .</action>
+     <action issue="COLLECTIONS-852" type="update" dev="ggregory" due-to="Claude Warren, Alex Herbert">Add layerd bloom filter clean method #476.</action>
      <!-- FIX -->
+     <action type="update" dev="ggregory" due-to="Gary Gregory">Deprecate Closure in favor of java.util.function.Consumer.</action>
      <!-- UPDATE -->
      <action type="update" dev="ggregory" due-to="Dependabot">Bump org.apache.commons:commons-parent from 67 to 69 #473.</action>
      <action type="update" dev="ggregory" due-to="Dependabot">Bump tests commons-io:commons-io from 2.16.0 to 2.16.1 #475 .</action>

diff --git a/src/main/java/org/apache/commons/collections4/Closure.java b/src/main/java/org/apache/commons/collections4/Closure.java
@@ -16,6 +16,8 @@
  */
 package org.apache.commons.collections4;
 
+import java.util.function.Consumer;
+
 /**
  * Defines a functor interface implemented by classes that do something.
  * <p>
@@ -29,9 +31,15 @@
  *
  * @param <T> the type that the closure acts on
  * @since 1.0
+ * @deprecated Use {@link Consumer}.
  */
-@FunctionalInterface
-public interface Closure<T> {
+@Deprecated
+public interface Closure<T> extends Consumer<T> {
+
+    @Override
+    default void accept(final T input) {
+        execute(input);
+    }
 
     /**
      * Performs an action on the specified input object.