[COLLECTIONS-812] fix flaky test due to timestamp comment inserted in… #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Properties methods.
A comment line is inserted after the comment given when using Properties#save(OutputStream, String), Properties#store(OutputStream, String) and Properties#store(Writer, String)
e.g.
#Sat Apr 30 22:00:30 HKT 2022
. Hence the test will fail when actual, expected content are not written in same second. To fix the problem, comparison will ignore this commentAdditional to [COLLECTIONS-812] Open both streams with try-with-resources, and assert that only the text is the same, not the time #305, also fix
testStoreToPrintWriter()
andtestSetProperty()
which are also usingProperties#store
Remove unnecessary
throws IOException
@kinow, should we keep using
Properties#save
for compatibility, or just useProperties#store
and rename the method totestStore
?