COMPRESS-375 Allow the deferred creation of ZipArchiveEntry for parallel zips
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamentotev
changed the title
ZipArchiveEntry for parallel zipsZipArchiveEntry for parallel zips
plamentotev
changed the title
ZipArchiveEntry for parallel zipsZipArchiveEntry for parallel zips
…allel zips In some cases when creating parallel zip archive the `ZipArchiveEntry` to be added could not be created before the `InputStream` is read. In those cases there is no point in passing `ZipArchiveEntry` and `InputStreamSupplier` as you can't actually defer the creation of the `InputStream` as it's needed for the `ZipArchiveEntry`. Add `ZipArchiveEntryRequestSupplier` to allow the deferred creation of both `ZipArchiveEntry` and `InputStream`.
|
Hmm, looks like @coveralls acts strange. The first time it says my commits are increasing the code coverage and after that they are decreasing it. And there are no code changes - I only fixed the commit message. |
|
Don't worry about Coveralls, I see the same behaviour for other projects as well. I think this is related to our Travis CI setup using different JDKs and Coveralls picks whichever build finishes first. For different JDKs you get slightly different coverage values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to implement the changes suggested in COMPRESS-375.