CPIO crc overflow resolved for large files #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unpacking a CPIO file containing a large file the crc check will
overflow and throw an IOException("CRC Error...").
Did not find a nice wa to test this since it requires a very lasrge
input file.
|
Great, many thanks, I've just found https://people.freebsd.org/~kientzle/libarchive/man/cpio.5.txt states
so your patch is certainly correct. I'm afraid we've got the same bug when writing CPIO archives. I'll take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unpacking a CPIO file containing a large file the crc check will
overflow and throw an IOException("CRC Error...").
Did not find a nice way to test this since it requires a very large
input file.