COMPRESS-579 - Remove redundant local variable #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodewig
reviewed
May 22, 2021
| @@ -569,7 +569,7 @@ public void testTarFileLongNameLargerThanBuffer() throws IOException { | |||
| } | |||
|
|
|||
| private String createLongName(final int nameLength) { | |||
| final StringBuffer buffer = new StringBuffer(); | |||
| final StringBuilder buffer = new StringBuilder(); | |||
There was a problem hiding this comment.
I don't see any redundant variable here :-)
I assume you added changes you intended to create as separate commits by accident. Please make sure your PR title and description matches what your change actually does.
There was a problem hiding this comment.
Yep, sorry.
It was intentionally, I didn't think another PR was necessary. Next time will be more careful
TY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.