COMPRESS-400 #27
Closed
COMPRESS-400 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n they're overly optimisic Add packageinfo files for per-package version settings. Initialize to 1.14 Copy packageinfo files in resource phase. Use latest bundle plugin. Remove superflous headers from manifest. Pretty-print the manifest. Add bundle:baseline to the verify phase Add bundle:baseline-report to the site phase To change the base version from default (i.e. previous release) set comparisonVersion property Change travis build goal to verify Signed-off-by: Simon Spero <sesuncedu@gmail.com>
One line of non copyrightable material does not need the license header :)
…of version info. Add build time dependency on org,osgi.annotation for Version annotation. Remove resource copy. Signed-off-by: Simon Spero <sesuncedu@gmail.com>
…ra PAX headers to tar archives Add extra header map to tar archive entry. Move PAX header processing code from TarArchiveInputStream to TarAchiveEntry. Use same code for processing user supplied extra headers - thus setting "size "changes the value of getSize(). Add any extra PAX headers to output map when putting entry in TarArchiveOutputStream. Add simple tests for getting/setting xattr, setting "size", and round tripping. This PR uses COMPRESS-399 as a base. To make it easier to cherry-pick, this commit does not bump the minor package version; this will cause the baseline verify stage in 399 to break the build, since the API has changed in a backwards compatible fashion A separate commit increases the package minor version. Signed-off-by: Simon Spero <sesuncedu@gmail.com>
org.apache.commons.compress.archivers.tar to 1.15.0 to reflect backwards compatible changes to API: [INFO] < org.apache.commons.compress.archivers.tar minor 1.15.0 1.14.0 1.15.0 - [INFO] < class org.apache.commons.compress.archivers.tar.TarArchiveEntry [INFO] + method addPaxHeader(java.lang.String,java.lang.String) [INFO] + method addXattr(java.lang.String,java.lang.String) [INFO] + method clearExtraPaxHeaders() [INFO] + method getExtraPaxHeader(java.lang.String) [INFO] + return java.lang.String [INFO] + method getExtraPaxHeaders() [INFO] + return java.util.Map<Ljava.lang.String;Ljava.lang.String;> [INFO] + method getXattr(java.lang.String) [INFO] + return java.lang.String [INFO] - version 1.14.0 [INFO] + version 1.15.0 Signed-off-by: Simon Spero <sesuncedu@gmail.com>
|
Thanks, do you think you could re-create the PR without the commits that belong to #26 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra header map to tar archive entry.
Move PAX header processing code from TarArchiveInputStream to TarAchiveEntry.
Use same code for processing user supplied extra headers - thus setting "size "changes the value of getSize().
Add any extra PAX headers to output map when putting entry in TarArchiveOutputStream.
Add simple tests for getting/setting xattr, setting "size", and round tripping.
This PR uses COMPRESS-399 as a base.
To make it easier to cherry-pick + rebase the PR has been split in two.
1d9b3c8 contains just the code changes and test changes, and does not bump the minor package version . This will cause the bundle:baseline verify goal in 399 to break the build.
82405c1 increases the package minor version to the correct value