Support preamble garbage in ZipArchiveInputStream

[kvr000]

zip can ignore any garbage at the beginning of file up to certain size. This is supported in ZipFile but not in ZipArchiveInputStream. This PR fixes that, including correct check for empty archive.

[codecov-commenter]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (86d2232) 80.64% compared to head (59777a1) 80.63%.
Report is 5 commits behind head on master.

Files	Patch %	Lines
.../compress/archivers/zip/ZipArchiveInputStream.java	87.80%	1 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #471      +/-   ##
============================================
- Coverage     80.64%   80.63%   -0.02%     
- Complexity     6777     6781       +4     
============================================
  Files           348      348              
  Lines         24901    24926      +25     
  Branches       4022     4029       +7     
============================================
+ Hits          20082    20098      +16     
- Misses         3298     3304       +6     
- Partials       1521     1524       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[garydgregory]

Hello @kvr000
Is this documented anywhere? PREAMBLE_GARBAGE_MAX_SIZE?

[kvr000]

Hello @kvr000 Is this documented anywhere? PREAMBLE_GARBAGE_MAX_SIZE?

I haven't found "official" support for skipping the garbage in the specification. zip program and ZipFile from apache compress naturally do it because they go backward from the end of central directory, though zip eventually prints a warning about garbage at the beginning.

I used 4096 as it should be enough for typical case when the program execution is added at the beginning: #!/usr/bin/env -S whatever with the arguments such as java -Xmx32M -jar

[garydgregory]

@kvr000
Thank you for the clarification; merged.