Replace custom 'dummy' byte addition for the odd inflater contract wi… #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th a sequence input stream. Clean up the code a bit. I did not use NOSONAR flags because I don't use sonar, so it may require some tweaking.
|
Also, to be honest -- this boundedinputstream has synchronized read methods and I've no idea why they're there. I don't think we have to create thread-safe streams here (is this a requirement anyhow?). This isn't included in the patch, but I'd drop synchronized from boundedinputstream entirely. |
|
your PR and 43e8d3d collided mid-flight, sorry about that, I'll incorporate a few of your changes that I have missed. Honestly, I don't recall why the methods are synchronized anymore either. |
|
No problem at all; sorry I missed that other place that was using the inflater (glad you spotted it); had kids on my back and couldn't focus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…th a sequence input stream. Clean up the code a bit. I did not use NOSONAR flags because I don't use sonar, so it may require some tweaking.