Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIGURATION-813: mailapi follow up #188

Merged
merged 2 commits into from Jun 16, 2022

Conversation

darkma773r
Copy link
Contributor

  • simplify mailapi type conversions

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one change noted.

@codecov-commenter
Copy link

Codecov Report

Merging #188 (c5c6227) into master (9a828da) will increase coverage by 0.04%.
The diff coverage is 62.50%.

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     89.42%   89.47%   +0.04%     
  Complexity     3604     3604              
============================================
  Files           183      183              
  Lines         10005    10000       -5     
  Branches       1352     1351       -1     
============================================
  Hits           8947     8947              
+ Misses          774      770       -4     
+ Partials        284      283       -1     
Impacted Files Coverage Δ
...ache/commons/configuration2/DataConfiguration.java 95.86% <ø> (ø)
...mons/configuration2/convert/PropertyConverter.java 75.41% <62.50%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a828da...c5c6227. Read the comment docs.

@asfgit asfgit merged commit c5c6227 into apache:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants