Minor changes #135
Merged
Minor changes #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arturobernalg
commented
Jun 16, 2021
•
arturobernalg
commented
- Replace with <>
- Simplify conditions and avoid extra checks.
- Use java array style
garydgregory
requested changes
Oct 20, 2021
| @@ -161,7 +161,7 @@ | |||
| * @return 1 for success and 0 for failure. | |||
| */ | |||
| public static native int EVP_CipherInit_ex(PointerByReference ctx, PointerByReference cipher, | |||
| PointerByReference impl, byte key[], byte iv[], int enc); | |||
| PointerByReference impl, byte[] key, byte[] iv, int enc); | |||
There was a problem hiding this comment.
No weird formatting please.
| @@ -133,7 +133,7 @@ | |||
| * @return 1 for success and 0 for failure. | |||
| */ | |||
| public static native int EVP_CipherInit_ex(PointerByReference ctx, PointerByReference cipher, | |||
| PointerByReference impl, byte key[], byte iv[], int enc); | |||
| PointerByReference impl, byte[] key, byte[] iv, int enc); | |||
There was a problem hiding this comment.
No weird formatting please.
| @@ -161,10 +161,6 @@ final protected int next(final int numBits) { | |||
| public void close() { | |||
| closeRdrandEngine(); | |||
| OpenSslNativeJna.ENGINE_cleanup(); | |||
|
|
|||
There was a problem hiding this comment.
Unless you've authored these comments or you know they are invalid, leave them alone please.
* Simplify conditions and avoid extra checks. * Use java array.
|
HI @garydgregory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.