Update gitignore to ignore idea and vscode #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about to rebase and respond to your feedback on #114.
Just wanted to propose some minor changes, though.
.gitignore
Edit: While I was at it, I opted to update the contents of .gitignore with the up-to-date revision on github/gitignore.
I can replace the link with
https://raw.githubusercontent.com/github/gitignore/6651bca9c83572f908474fc6206ed8a80df91290/Maven.gitignore
if preferred?I prefer the current link, but whatever suits you.
.editorconfigFor those using code editors like Visual Studio Code, it can be easier if the project defines its preferences using EditorConfig to override any program settings. (a vendor-agnostic configuration file that many code editors support)I've just taken the EditorConfig configuration from the most starred Java project Apache has on GitHub:https://github.com/apache/dubbo/blob/3.0/.editorconfig
It could be worth considering if you'd want to change anything about it, for example I think something like this might be better: