Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMAIL-138: Do not automatically encode filename #10

Closed
wants to merge 0 commits into from

Conversation

vrozkovec
Copy link

As of javax.mail 1.5.6, javax.mail.internet.MimeBodyPart contains the method
static void setFileName(MimePart part, String name)
that allows user to choose to encode the filename by MimeUtility.encodeText(name). Automatically encoding of filename should not be done in commons-email, but in javax.mail.

See issue https://issues.apache.org/jira/browse/EMAIL-138

@vrozkovec
Copy link
Author

@markt-asf Hi, I've closed my previous PR and created new one, now without merge conflicts. Today I've again stumbled upon the same error when attaching filenames with UTF-8.
Thanks for consideration and eventual merge.

@vrozkovec vrozkovec changed the title Do not automatically encode filename EMAIL-138: Do not automatically encode filename Oct 10, 2019
@xfh
Copy link

xfh commented Jan 16, 2020

Hi @garydgregory, what is blocking this pull request? I'm also affected by this issue. Umlauts break due to the encoding.

If removing the encoding completely goes too far, how about enabling it conditionally as in javax.mail:
https://github.com/eclipse-ee4j/mail/blob/master/mail/src/main/java/javax/mail/internet/MimeBodyPart.java#L1296

This would fix two issues:
https://issues.apache.org/jira/browse/EMAIL-189
https://issues.apache.org/jira/browse/EMAIL-138

@Gragx
Copy link

Gragx commented Jan 20, 2020

https://issues.apache.org/jira/browse/EMAIL-181
Is yet another issue that would probably be solved by this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants