[EMAIL-192] Update code for Java 7 and other clean ups. #16
Conversation
also suggests: delete this function and change to StringUtils.isEmpty. the duplication seems meaningless.
|
advice: |
garydgregory
changed the title
| @@ -406,6 +406,36 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <plugin> | |||
There was a problem hiding this comment.
@XenoAmess
The PR looks good but I am wondering why we need to configure the Javadoc plugin here. If there is something missing in the parent POM, we should fix it there. What is this doing for you that the parent is not?
There was a problem hiding this comment.
@XenoAmess
The PR looks good but I am wondering why we need to configure the Javadoc plugin here. If there is something missing in the parent POM, we should fix it there. What is this doing for you that the parent is not?
@garydgregory
Yes I do have a reason to do so.
to repreduce what I met, please follow the steps below:
(my environment win10x64, openjdk13, but I don't think environment will matter much in this problem)
-
clone this pr in your pc.
-
see what I changed in this line: https://github.com/apache/commons-email/pull/16/files/6a9fe4a9ff73a1119c3624f8d861b01d7c6715fd#diff-77fad0477b22b44d8e52db08a61ff77eL63
-
please revert it back to the line content which before I commit the change,
means/** pattern for extracting <img> tags */. -
run
mvn packagefor this repo. -
see the build error reported.
-
please go delete the maven-javadoc-plugin in pom.xml.
-
run
mvn packagefor this repo. -
see the build success reported.
So for conclusion, I add this plugin here in this pom to [force javadoc be correct], by forcing maven fail if [javadoc be uncorrect].
I have no idea whether we can change something in commons-parent to have a same outcome without adding javadoc plugin in this repo. I'm not that familiar with complex maven repos management.
|
I'm making some unit tests for the regex I added. |
bugfix for regex. (sigh...every time I try to make a regex using java I must fail something)
|
tests for new added functions done. |
XenoAmess
changed the title
XenoAmess
changed the title
XenoAmess
changed the title
… develop � Conflicts: � pom.xml � src/main/java/org/apache/commons/mail/HtmlEmail.java
|
Hi. So what should we do next for this pr? |
|
Closing: Out of date. |
No description provided.