EXEC-105: fix documentation #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecki
reviewed
Jul 16, 2023
| @@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler); | |||
|
|
|||
| // some time later the result handler callback was invoked so we | |||
| // can safely request the exit value | |||
| int exitValue = resultHandler.waitFor(); | |||
| resultHandler.waitFor(); | |||
There was a problem hiding this comment.
I would also show the exitValue = resultHandler.getExitValue(); call as the comment suggests.
There was a problem hiding this comment.
Hi @ecki,
Does the PR look ok to you now?
There was a problem hiding this comment.
Looks good - maybe in the future we should use snippets or at least have a copy in a test class.
you might need to add the changes.xml entry?
There was a problem hiding this comment.
@ecki updated changes.xml
There was a problem hiding this comment.
In general, don't update changes.xml, if every PR did that, they would all create merge problems. Note that "dev" is for Apache IDs and "due-to" is for contributor IDs that can be tied so something, like a GitHub account.
Replace "dev" with "due-to" public GitHub name. Sentences end in a period.
garydgregory
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXEC-105: fixed documentation