FILEUPLOAD-348 - Add tests (already pass in 2.0). (#200)

apache · Feb 8, 2023 · a00263b · a00263b
1 parent 04f20fc
commit a00263b
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/src/test/java/org/apache/commons/fileupload2/DiskFileItemSerializeTest.java b/src/test/java/org/apache/commons/fileupload2/DiskFileItemSerializeTest.java
@@ -87,9 +87,25 @@ public void testInMemoryObject(final byte[] testFieldValueBytes, final File repo
         } catch (UncheckedIOException e) {
             fail("Unexpected IOException", e);
         }
+        testWritingToFile(item, testFieldValueBytes);
         item.delete();
     }
 
+    /**
+     * Helper method to test writing item contents to a file.
+     */
+    public void testWritingToFile(final FileItem item, final byte[] testFieldValueBytes) {
+        try {
+            final File temp = File.createTempFile("fileupload", null);
+            // Note that the file exists and is initially empty;
+            // write() must be able to handle that.
+            item.write(temp);
+            compareBytes("Initial", FileUtils.readFileToByteArray(temp), testFieldValueBytes);
+        } catch (Exception e) {
+            fail("Unexpected Exception", e);
+        }
+    }
+
     /**
      * Helper method to test creation of a field.
      */
@@ -138,6 +154,7 @@ public void testAboveThreshold() {
             fail("Unexpected IOException", e);
         }
 
+        testWritingToFile(item, testFieldValueBytes);
         item.delete();
     }