Adding capability to take max upload size per request.Fileupload 1 3 1

[codecracker2014]

As of now FileUploadBase has sizeMax which is global for all uploads, in many cases it is required to calculate this limit based on request.

https://stackoverflow.com/questions/16585866/changing-file-size-limit-maxuploadsize-depending-on-the-controller

[garydgregory]

I'm pretty sure no one is looking at old branches for this component. You should based your PR off of master.
This PR needs tests. There is also no documentation for the new feature.

[jochenw]

1. I'd support Gary's request, that you provide a PR for the current master, and not the stable branch.

2. Well spotted, that you should use the RequestContext, to support both the servlet, and the portlet case!

3. Rather than using a method getSizeMaxForThisRequest, I'd suggest a more general approach, (The 1.4 branch is still open for API changes.) such as:

   • Replace

FileItemStream FileUploadBase.getItemIterator(RequestContext pCtx)

with a method

FileItemRequest getItemIterator(RequestContext pCtx)

where FileItemRequest would contain methods like

void setMaxUploadSizeExceeded(Predicate<Long> pPredicate) {
}
FileItemStream getItemIterator();

On the other hand, rethinking that, it is probably a better idea, if I do that myself.

[jochenw]

Please close in favour of FILEUPLOAD-300.

[codecracker2014]

@jochenw i implemented current solution avoiding breaking changes for 1.3.1, but i agree with you for master, we can do it with api changes. Also i'll do more brainstorming on this feature. Closing this PR in favour of FILEUPLOAD-300.