Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FILEUPLOAD-274: RFC 5987 compliance #24

Merged
merged 2 commits into from May 25, 2020
Merged

FILEUPLOAD-274: RFC 5987 compliance #24

merged 2 commits into from May 25, 2020

Conversation

anselm94
Copy link
Contributor

RFC 5987 adds support for encoding mechanism for use in MIME headers in HTTP headers. It recommends following formats

  • ASCII charset: <paramname>: <paramvalue>
  • Non ASCII Charset: <paramname>*: <charset>'<lang>'<percent-encoded>

The specification has following things to say

  • RFC 2231 - MIME Type extension for Email and other protocols to support multiple charsets and languages. (Having Asterisks (*) at the end of parameter name for extensions)

  • RFC 5987 - Extends on RFC 2231 for extended charsets and languages, but restricts charsets to UTF-8 and ISO-8859-1 and no continuations (multiple extensions for same param name) as HTTP headers has no limitations in header size

  • RFC 7578 - Extends on RFC 5987 specifically for multipart/form-data, but rejects usage of Asterisks (*)

@anselm94
Copy link
Contributor Author

Still some of the older implementations like Apache OpenCMIS Chemistry libraries uses RFC 5987 (formulated in 2010), as RFC 7578 came later in 2015. The library has both server and clients, which breaks currently without RFC 7578 for an experimental implementation of Streaming support via Commons-FileUpload.
If the library has to be patched, then all the clients & server implementations have to migrate to the latest patch, which is not practical

@coveralls
Copy link

coveralls commented Dec 10, 2019

Coverage Status

Coverage increased (+0.5%) to 79.35% when pulling 1a8a103 on anselm94:FILEUPLOAD-274-RFC5987-compliance into e8124ca on apache:master.

@anselm94
Copy link
Contributor Author

@team any update on this PR?

@kinow
Copy link
Member

kinow commented Dec 17, 2019

Hi @anselm94 I had a quick read at the issue and the code, but I feel like I would need more time to read more of both RFC's mentioned in the JIRA issue to be able to review the code.

Given this is the last few days of the year before holidays, I think others might be busy preparing everything at work for the long holiday ahead.

So it may take a while to be reviewed by others 👍 I will spend part of my holiday working on open source, including ASF. So I may have time to review this one near NYE.

Cheers
Bruno

@anselm94
Copy link
Contributor Author

Thanks @kinow for the update. I understand 😄

I was perplexed by complete silence in here and was wondering if I should raise a PR in SVN codeline

Question: When is the next release scheduled for Apache Fileupload ? Or any patches for 1.4?

@kinow
Copy link
Member

kinow commented Dec 17, 2019

It depends. It is up to someone volunteering to prepare the release.

You can try sending an e-mail to the dev list too if you'd like.

@anselm94
Copy link
Contributor Author

Thanks @kinow Will do that

@michael-o michael-o changed the title FILEUPLOAD-274: RFC-5987 compliance FILEUPLOAD-274: RFC 5987 compliance May 3, 2020
asfgit pushed a commit that referenced this pull request May 25, 2020
@asfgit asfgit merged commit d612165 into apache:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants