Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Improvement: #50

Closed
wants to merge 1 commit into from
Closed

Minor Improvement: #50

wants to merge 1 commit into from

Conversation

arturobernalg
Copy link
Member

@arturobernalg arturobernalg commented Dec 27, 2020 •
edited
Loading

  • Add final
  • Remove Unused import
  • Remove Unnecessary interface modifier
  • Use Standard Charset object
  • Fix JavaDoc
  • Replace with computeIfAbsent

@coveralls
Copy link

coveralls commented Dec 27, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 78.327% when pulling 865ee24 on arturobernalg:feature/minor_improvement into 80385a1 on apache:master.

@arturobernalg
Minor Improvement:
865ee24 
* Add final
* Remove Unused import
* Remove Unnecessary interface modifier
* Use Standard Charset object
* Fix JavaDoc
* Replace with computeIfAbsent
@jochenw
Copy link
Contributor

jochenw commented Dec 27, 2020 •
edited
Loading

The fact, that you are changing no less than 20 files here, is an obvious contradiction to a "Minor Improvement". Could you, please, simplify that a lot, until I can inspect your changes one by one? Thanks!

@jochenw
Copy link
Contributor

jochenw commented Dec 29, 2020

Sorry, mismatched this PR with another one on commons-fileupload. However, my opinion remains: 24 affected files is way too much for "minor improvements".

@arturobernalg arturobernalg deleted the feature/minor_improvement branch December 30, 2020 08:03
@arturobernalg
Copy link
Member Author

OK, I close the PR and split into 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@arturobernalg @coveralls @jochenw