Reverting name change after discussion on dev ML.

This reverts commit 3c25e07.
apache · Jul 7, 2020 · 8df6909 · 8df6909
1 parent afde7ad
commit 8df6909
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/...e/internal/GeometryInternalException.java → .../core/internal/GeometryInternalError.java b/...e/internal/GeometryInternalException.java → .../core/internal/GeometryInternalError.java
@@ -20,7 +20,7 @@
  * This class is not intended to be part of the public API and should
  * never be seen by the user when algorithms are functioning correctly.
  */
-public class GeometryInternalException extends IllegalStateException {
+public class GeometryInternalError extends IllegalStateException {
 
     /** Error message used for exceptions of this type. */
     private static final String ERROR_MSG = "An internal geometry error occurred. This most often indicates an " +
@@ -32,7 +32,7 @@ public class GeometryInternalException extends IllegalStateException {
 
     /** Simple constructor with a default error message.
      */
-    public GeometryInternalException() {
+    public GeometryInternalError() {
         super(ERROR_MSG);
     }
 }
diff --git a/...ternal/GeometryInternalExceptionTest.java → ...e/internal/GeometryInternalErrorTest.java b/...ternal/GeometryInternalExceptionTest.java → ...e/internal/GeometryInternalErrorTest.java
@@ -19,12 +19,12 @@
 import org.junit.Assert;
 import org.junit.Test;
 
-public class GeometryInternalExceptionTest {
+public class GeometryInternalErrorTest {
 
     @Test
     public void testMessage() {
         // act
-        final GeometryInternalException err = new GeometryInternalException();
+        final GeometryInternalError err = new GeometryInternalError();
 
         // assert
         final String msg = "An internal geometry error occurred. This most often indicates an " +

diff --git a/...geometry-enclosing/src/main/java/org/apache/commons/geometry/enclosing/WelzlEncloser.java b/...geometry-enclosing/src/main/java/org/apache/commons/geometry/enclosing/WelzlEncloser.java
@@ -20,7 +20,7 @@
 import java.util.List;
 
 import org.apache.commons.geometry.core.Point;
-import org.apache.commons.geometry.core.internal.GeometryInternalException;
+import org.apache.commons.geometry.core.internal.GeometryInternalError;
 import org.apache.commons.geometry.core.precision.DoublePrecisionContext;
 
 /** Class implementing Emo Welzl's algorithm to find the smallest enclosing ball in linear time.
@@ -98,7 +98,7 @@ private EnclosingBall<P> pivotingBall(final Iterable<P> points) {
             ball = moveToFrontBall(extreme, extreme.size(), support);
             if (precision.lt(ball.getRadius(), savedBall.getRadius())) {
                 // this should never happen
-                throw new GeometryInternalException();
+                throw new GeometryInternalError();
             }
 
             // it was an interesting point, move it to the front

diff --git a/...c/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java b/...c/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java
@@ -19,7 +19,7 @@
 import java.util.Objects;
 import java.util.function.DoubleFunction;
 
-import org.apache.commons.geometry.core.internal.GeometryInternalException;
+import org.apache.commons.geometry.core.internal.GeometryInternalError;
 import org.apache.commons.geometry.euclidean.internal.Vectors;
 import org.apache.commons.geometry.euclidean.threed.AffineTransformMatrix3D;
 import org.apache.commons.geometry.euclidean.threed.Vector3D;
@@ -382,7 +382,7 @@ private double[] getAngles(final AxisReferenceFrame frame, final AxisSequence ax
         }
 
         // all possibilities should have been covered above
-        throw new GeometryInternalException();
+        throw new GeometryInternalError();
     }
 
     /** Get a sequence of angles around the given Tait-Bryan axes that produce a rotation equivalent