[IO-483] FilenameUtils.getPrefixLength fix for unix files/folders starting with colon #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles/folder that are in the root folder and start with colons
|
I think the proposed solutions works with no regressions in the code. Checked out the pull request locally, played with the tests adding a few other entries, but found no issues. Will leave it open for others to review. Might be interesting to add the new test case examples to the method Javadoc too, IMO. |
|
Thank you for the quick follow up. |
asfgit
pushed a commit
that referenced
this pull request
Dec 2, 2016
IO-483: getPrefixLength return -1 if unix file contains colon This closes #19 Thanks to @marko-vasic
|
Pull request merged. Mentioned you in the issue entry in changes.xml @marko-vasic. Let me know if your name is not Marko Vasic, or if you'd like me to use a different in that file. commons-io/src/changes/changes.xml Line 50 in 593de77 And thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilenameUtils.getPrefixLength now works correctly for unix files/folder that are in the root folder and start with colons