Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO-789 Symbolic link file filter accepts all files, not just symbolic links #449

Conversation

SwingGuy1024
Copy link
Contributor

This change fixed the filters, but also restructures the code slightly to facilitate Unit Testing on all platforms. (This is a challenge for this particular class.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #449 (ba878ad) into master (22f6525) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master     #449   +/-   ##
=========================================
  Coverage     84.62%   84.62%           
- Complexity     3291     3292    +1     
=========================================
  Files           223      223           
  Lines          7913     7914    +1     
  Branches        946      946           
=========================================
+ Hits           6696     6697    +1     
  Misses          970      970           
  Partials        247      247           
Impacted Files Coverage Δ
.../commons/io/filefilter/SymbolicLinkFileFilter.java 87.50% <66.66%> (+1.78%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garydgregory
Copy link
Member

@SwingGuy1024
You have 2 similar PRs for this class and this one does not have a unit test. Which PR do you want us to review?

@garydgregory
Copy link
Member

Superceded by #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants