Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new function: byteCountToDisplayRoundedSize #74

Closed
wants to merge 5 commits into from
Closed

Add new function: byteCountToDisplayRoundedSize #74

wants to merge 5 commits into from

Conversation

zsoltii
Copy link

@zsoltii zsoltii commented Mar 1, 2019

@coveralls
Copy link

coveralls commented Mar 1, 2019

Coverage Status

Coverage increased (+0.1%) to 88.461% when pulling 038083c on zsoltii:master into 2fc4236 on apache:master.

@zkendall
Copy link

Would love this feature!

@rainermueller
Copy link

PR not in last release 2.11.0, when will the change be provided?

@RockyMM
Copy link

RockyMM commented Nov 9, 2022

@zsoltii your solution looks pretty cool. Could you resolve conflics, or are you OK if I take over the PR and resolve them?

@garydgregory
Copy link
Member

I do not think number-text conversion routines belong in Commons IO. Maybe in Commons Text?

@RockyMM
Copy link

RockyMM commented Nov 14, 2022

@garydgregory I think this is more about byte/bit display handling. Another perspective is that the migration to Commons Text a bit extending the scope. This is about improving the current function, which has its drawbacks, with a better implementation. Once we have this, the function could be migrated to Commons Text if all stakeholders agree.

@garydgregory
Copy link
Member

Hello @zsoltii
My main point is that the functionality should not have been put here in the first place, it has nothing to do with IO; consequently, let's not make it bigger.

@RockyMM
Copy link

RockyMM commented Nov 16, 2022

Hey @garydgregory,

On a second thought, you do have a point.

Then I would suggest we move the functionality to CommonsText, and create an issue that will mark all of these methods as @Deprecated.

@garydgregory
Copy link
Member

Hi @RockyMM
Go for it ;-)

@garydgregory
Copy link
Member

Closing, moving to Commons Text (presumably).

@eric-creekside
Copy link

Any link to the corresponding Commons Text PR or other way to track this down?

@youngledo
Copy link

Closing, moving to Commons Text (presumably).

Excuse me, how's it going?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants