Fixed a mistake in the FilenameUtils.concat()'s Javadoc about an absolute path. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stzx
approved these changes
Sep 10, 2019
|
The Travis CI build failed, what should I do? |
|
This should be a fake failure. |
|
This could be a random failure and certainly should not be affected by a Javadoc changes. @yuji-k64613 : If you want to be credited, please update |
yuji-k64613
changed the title
Stzx
suggested changes
Sep 11, 2019
src/changes/changes.xml
Outdated
| @@ -134,6 +134,9 @@ The <action> type attribute can be add,update,fix,remove. | |||
| <action issue="IO-625" dev="ggregory" type="fix" due-to="Mikko Maunu"> | |||
| Corrected misleading exception message for FileUtils.copyDirectoryToDirectory. | |||
| </action> | |||
| <action issue="IO-626" dev="Yuji Konishi" type="fix" due-to="Yuji Konishi"> | |||
There was a problem hiding this comment.
Normally the dev is a committer, and due-to is the PR contributor name/alias.
There was a problem hiding this comment.
Sorry.
I thought that a committer and the PR contributor are me.
Which is my mistake, a committer or the PR contributor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng
/foo/a/ + ../bar --> foo/bar
ok
/foo/a/ + ../bar --> /foo/bar