More parser compatibility fixes for JavaCC/JJTree #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why STATIC=false was commented out? Without it, generating the parser with JavaCC does not work. The Parser constructor taking String throws ParseException (a checked exception) when generated with JavaCC. I'm not sure why, but the StringProvider exception does not. For the pragmaValue changes, unreachable statements were generated. See http://consoliii.blogspot.com/2014/05/javacc-modern-mode-how-to-resolve.html With these changes I'm able to use JavaCC and everything passes again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why STATIC=false was commented out? Without it, generating
the parser with JavaCC does not work.
The Parser constructor taking String throws ParseException (a checked
exception) when generated with JavaCC. I'm not sure why, but the
StringProvider exception does not.
For the pragmaValue changes, unreachable statements were generated. See
http://consoliii.blogspot.com/2014/05/javacc-modern-mode-how-to-resolve.html
With these changes I'm able to use JavaCC and everything passes again.