LANG-1349: EqualsBuilder#isRegistered: swappedPair construction bug

Modify test to clean-up registry at the end.
apache · Sep 8, 2017 · fdf05fa · fdf05fa
1 parent a2dce32
commit fdf05fa
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
@@ -1346,12 +1346,18 @@ public void testIsRegistered() throws Exception {
         Object firstObject = new Object();
         Object secondObject = new Object();
 
-        Method registerMethod = MethodUtils.getMatchingMethod(EqualsBuilder.class, "register", Object.class, Object.class);
-        registerMethod.setAccessible(true);
-        registerMethod.invoke(null, firstObject, secondObject);
-
-        assertTrue(EqualsBuilder.isRegistered(firstObject, secondObject));
-        assertTrue(EqualsBuilder.isRegistered(secondObject, firstObject)); // LANG-1349
+        try {
+            Method registerMethod = MethodUtils.getMatchingMethod(EqualsBuilder.class, "register", Object.class, Object.class);
+            registerMethod.setAccessible(true);
+            registerMethod.invoke(null, firstObject, secondObject);
+
+            assertTrue(EqualsBuilder.isRegistered(firstObject, secondObject));
+            assertTrue(EqualsBuilder.isRegistered(secondObject, firstObject)); // LANG-1349
+        } finally {
+            Method unregisterMethod = MethodUtils.getMatchingMethod(EqualsBuilder.class, "unregister", Object.class, Object.class);
+            unregisterMethod.setAccessible(true);
+            unregisterMethod.invoke(null, firstObject, secondObject);
+        }
     }
 }