Hash code builder

[mureinik]

Solution for LANG-804: Redundant check for zero in HashCodeBuilder ctor

[kelvinst]

Nice PR, I'd like the test added and the rename of them to clarify what they really tests...
Maybe add some tests with odd values tests, positive and negative, will be great 😃

[britter]

@mureinik I'd like to apply your changes to my svn working copy for review but I'm having troubles to generate an appropriate diff file. Do you know how to do the trick?

[mureinik]

@kelvinst I'd be happy to add more tests, but I'm not quite clear what you're suggesting. Just adding one-liners that make sure that new HashCodeBuilder(-17, -37) does not throw an IllegalArgumentException?
Something more?

Note that HashCodeBuilderTest is full of calls to new HashCodeBuilder(17, 37), so we pretty much have that covered :-)

[mureinik]

@britter it's been a while since I worked with SVN, but this should do the trick:
https://github.com/apache/commons-lang/pull/10.diff (note that this includes both patches - the test enhancement/cleanup and the LANG-804 solution).

Alternatively, if you pull to a local git you could just do something like this and create the patches locally:
git format-patch -n2 -o /tmp/HashCodeBuilder

Does this do the trick for you?

[britter]

@mureinik I've applied your patch in r1526817. Thanks for contributing!

[mureinik]

@britter thanks for applying it. Happy to help :-)

[kelvinst]

Sorry, I didn't saw that other tests ;D... This can be close now, right?

[mureinik]

@kelvinst didn't notice the request stayed open, thanks.
Closing.