Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LANG-1269: Wrong name or result of StringUtils#getJaroWinklerDistance #198

Closed
wants to merge 1 commit into from
Closed

LANG-1269: Wrong name or result of StringUtils#getJaroWinklerDistance #198

wants to merge 1 commit into from

Conversation

PascalSchumacher
Copy link
Contributor

deprecat StringUtils#getJaroWinklerDistance and add StringUtils#getJaroWinklerSimilarity instead

@coveralls
Copy link

coveralls commented Oct 22, 2016 •
edited

Coverage Status

Coverage increased (+0.004%) to 93.545% when pulling d2e6338 on PascalSchumacher:jarowinklerdistance_name into 91d6bd7 on apache:master.

@kinow
Copy link
Member

kinow commented Oct 22, 2016

+1

@PascalSchumacher
LANG-1269: Wrong name or result of StringUtils#getJaroWinklerDistance
436d280 
deprecate StringUtils#getJaroWinklerDistance and add StringUtils#getJaroWinklerSimilarity instead
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.57% when pulling 436d280 on PascalSchumacher:jarowinklerdistance_name into 8274993 on apache:master.

@coveralls
Copy link

coveralls commented Oct 22, 2016 •
edited

Coverage Status

Coverage increased (+0.004%) to 93.552% when pulling 436d280 on PascalSchumacher:jarowinklerdistance_name into 8274993 on apache:master.

@asfgit asfgit closed this in a40b2a9 Oct 28, 2016
asfgit pushed a commit that referenced this pull request Mar 19, 2017
@PascalSchumacher
Revert "LANG-1269: Wrong name or result of StringUtils#getJaroWinkler…
f4ee399 
…Distance (closes #198)"

This reverts commit a40b2a9, because adding a new method StringUtils#getJaroWinklerSimilarity and immediately deprecating it makes not sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@PascalSchumacher @coveralls @kinow