Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LANG-1034: Recursive and reflective EqualsBuilder #202

Closed
wants to merge 2 commits into from
Closed

LANG-1034: Recursive and reflective EqualsBuilder #202

wants to merge 2 commits into from

Conversation

PascalSchumacher
Copy link
Contributor

patch by yathos UG

@coveralls
Copy link

coveralls commented Oct 23, 2016 •
edited

Coverage Status

Coverage decreased (-0.03%) to 93.424% when pulling b6eee76 on PascalSchumacher:recursiveAndReflectiveEqualsBuilder into eb2b89e on apache:master.

@PascalSchumacher
Copy link
Contributor Author

PascalSchumacher commented Oct 23, 2016 •
edited

I haven't locked at this in-depth yet, but seems like a useful enhancement.

@PascalSchumacher PascalSchumacher force-pushed the recursiveAndReflectiveEqualsBuilder branch from b6eee76 to f4cf194 Compare October 23, 2016 18:08
@coveralls
Copy link

coveralls commented Oct 23, 2016 •
edited

Coverage Status

Coverage decreased (-0.04%) to 93.442% when pulling f4cf194 on PascalSchumacher:recursiveAndReflectiveEqualsBuilder into 89afbb0 on apache:master.

@PascalSchumacher PascalSchumacher force-pushed the recursiveAndReflectiveEqualsBuilder branch from f4cf194 to 2d6ce6a Compare November 6, 2016 18:44
@coveralls
Copy link

coveralls commented Nov 6, 2016 •
edited

Coverage Status

Coverage decreased (-0.007%) to 93.555% when pulling 2d6ce6a on PascalSchumacher:recursiveAndReflectiveEqualsBuilder into 05647d4 on apache:master.

@PascalSchumacher PascalSchumacher force-pushed the recursiveAndReflectiveEqualsBuilder branch from 2d6ce6a to b8c7336 Compare November 6, 2016 22:34
@coveralls
Copy link

coveralls commented Nov 6, 2016 •
edited

Coverage Status

Coverage decreased (-0.02%) to 93.542% when pulling b8c7336 on PascalSchumacher:recursiveAndReflectiveEqualsBuilder into 05647d4 on apache:master.

@PascalSchumacher
LANG-1034: Recursive and reflective equals builder
015fb11 
minimal clean-up: remove getter methods, improve javadoc
@PascalSchumacher PascalSchumacher force-pushed the recursiveAndReflectiveEqualsBuilder branch from b8c7336 to 015fb11 Compare November 6, 2016 22:40
@coveralls
Copy link

coveralls commented Nov 6, 2016 •
edited

Coverage Status

Coverage decreased (-0.02%) to 93.542% when pulling 015fb11 on PascalSchumacher:recursiveAndReflectiveEqualsBuilder into 05647d4 on apache:master.

@asfgit asfgit closed this in 0095d8a Nov 13, 2016
asfgit pushed a commit that referenced this pull request Nov 13, 2016
@PascalSchumacher
LANG-1034: Add support for recursive comparison to EqualsBuilder#refl…
0f6a292 
…ectionEquals (closes #202)

minimal clean-ups: remove getter methods, improve javadoc, add unit test for reflectionAppend
@douddle
Copy link

douddle commented Oct 3, 2017 •
edited

I start to use your feature and I discover a bug.
String are now compared with internal data (hash and char[]). But sometimes hash value is not initialized, this is probably a cache for the hashcode. So the comparison fails even if the char[] content is the same.
You should add the bypass for basic JRE classes (String, Datetime types, etc.)

@PascalSchumacher
Copy link
Contributor Author

@douddle I created https://issues.apache.org/jira/browse/LANG-1356 to track the bypass issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@PascalSchumacher @coveralls @douddle