LANG-1303 : Escape HTML characters once #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents single, double or recursive escaping of html characters.
…gregateTranslator. 2. Added escapeHtml3Once() method. 3. Commenting improvements.
…mmons-lang into escape_html_once
|
Thanks for the pull request. 👍 StringEscapeUtils was ported to commons-text and will soon deprecated in commons-lang. It would be nice if you could open a pull request at https://github.com/apache/commons-text Thanks! |
|
Thanks Pascal. |
|
Thanks Sampanna! It would be nice if you would close this pull request. (I can not do it easily as this is a read-only repository.) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first time contributing to any open source project.
The feature goes as follows:
If already escaped HTML characters are in the input test, they get escaped again using StringEscapeUtils.escapeHtml4().
For example:
If the input is:
100 kg < 1000kg
Then the output of escapeHtml4() becomes:
100kg &lt; 1000kg
At my workplace, we felt the need for a method in StringEscapeUtils which does not escape already escaped characters.