LANG-1453: using toUpperCase instead of toLowerCase solve the problem

[geratorres]

I changed the using of toLowerCase to toUpperCase on replace function on StringUtils. more detailed info is in a comment on Jira

[coveralls]

Coverage increased (+0.007%) to 95.396% when pulling e510d42 on geratorres:LANG-1453-IdxOutBndsEx into 6934228 on apache:master.

[cesarte789]

Please, review the conversation of the pull request #340
It seems that using String#toUpperCase instead of String#toLowerCase doesn't fix all the cases.

[chtompki]

We need to minimally replace "İ" with "\u0130" for this to properly work. For example try running:

System.out.println("İ");
System.out.println("\u0130");

only the second will give your desired output. That said, your point is still quite valid.

[chtompki]

I agree with @cesartxt - it seems that this resolves the unit tests as written for StringUtils, but the question becomes are there similar lower case letters that would yield a similar result when ran through toUpperCase.

[chtompki]

An example of another character that has this problem from the lowercase alphabet is ʼn or \u0149. So the question becomes how do we accommodate for these oddities? I'm open to thoughts here

[garydgregory]

Some background: https://garygregory.wordpress.com/2015/11/03/java-lowercase-conversion-turkey/

[chtompki]

Another non-deprecated Unicode character that has this IndexOutOfBoundsException as well is \uFB01 or fi after switching to use toUpperCase as opposed to toLowerCase.

and

yes @garydgregory there is a point here as I read an article that proported that there was at least one Turkish loss of life due to a cell phone mistranslating the specific character in question in the proposed tests for LANG-1453

[geratorres]

Thanks! for the context with this new info I'll be trying to find a good solution

[chtompki]

Yeah. I fiddled with it some today and didn’t see any clever solution that wasn’t brute force. I think we may have to check both situations.

[geratorres]

Closing this pull request because doesn't resolve the problem and the issue is duplicated with LANG-1406