Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LANG-1465: Fix for the time zone format -0530 should be accepted for … #436

Closed
wants to merge 1 commit into from
Closed

LANG-1465: Fix for the time zone format -0530 should be accepted for … #436

wants to merge 1 commit into from

Conversation

saksham93
Copy link

…ZZ format.

https://issues.apache.org/jira/projects/LANG/issues/LANG-1465
Added test case for the same

michael-o
michael-o requested changes Jul 27, 2019
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejecting this because it does not comply to ISO 8601 extended timezone format. You are not allowed to mix basic and extended format. You also have changed the non-capturing group to a capturing one.

@saksham93 saksham93 closed this Jul 27, 2019
@saksham93 saksham93 deleted the BugFix/LANG-1465-date-utils branch July 27, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@saksham93 @michael-o