WIP [LANG-1490] - Creates DiffResultView and DiffView classes #457
Conversation
0x6e69636f
changed the title
|
Hi @NicolasBD , Both files are missing the Apache license header causing CI build failures: https://travis-ci.org/apache/commons-lang/builds/584638020?utm_source=github_status&utm_medium=notification Gary |
|
@garydgregory ok I'll add it, but what do you think about the idea itself ? I'll add proper headers and tests once we decide if this should be added to the lib |
|
Let me take a closer look this weekend. In the meantime, I would also like to work on a patch that defines as This will allow diffs on a class and one of its subclasses for example. |
There was a problem hiding this comment.
Looks like a very interesting addition to [lang] @NicolasBD ! Had a quick read at the code, and it looks good! Thanks for the PR.
Few comments, mainly about the Checkstyle reports. It would be really helpful if you could rebase your branch, and then run mvn or just push to your branch and wait for the Travis build to validate the changes.
We also have some diff algorithms for text in Commons Text. I wonder if later the API's would converge or have something in common - https://github.com/apache/commons-text/tree/master/src/main/java/org/apache/commons/text/diff
Bruno
| * @param rightValue holds the string representation of the value in the right side of the comparison. | ||
| */ | ||
| public DiffView(String field, String leftValue, String rightValue) { | ||
| this.field = field; |
There was a problem hiding this comment.
I think the files were formatted with tabs, and this may cause issues in Travis when it builds using Checkstyle.
| @@ -0,0 +1,64 @@ | |||
| package org.apache.commons.lang3.builder; | |||
There was a problem hiding this comment.
I think this file is missing the copyright license header.
| .stream() | ||
| .map(DiffView::new) | ||
| .collect(Collectors.toList()) | ||
| ); |
There was a problem hiding this comment.
Probably will fail checkstyle due to tabs here, instead of spaces.
Currently, a DiffResult and a Diff can only handle the differences of two objects of the same type A, and we cannot set custom differences for a DiffResult if encapsulated objects of type B are different.
I suggest to implement a
DiffView classas a simpleString field,String leftValueandString rightValuetriplet.I also wrote a
DiffResultViewclass holding two objects of typeTand a list ofDiffViewobjects.https://issues.apache.org/jira/browse/LANG-1490