New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LANG-1530 another method like formatDurationWords with #506
base: master
Are you sure you want to change the base?
Conversation
src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java
Outdated
Show resolved
Hide resolved
+1 I had a quick look at the code, but didn't want to prepare a review before checking if we run the risk of needing one more test to display time zone with micro seconds, and yet more methods for other things. Good idea on looking at the SDK classes first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikolajmitura whenever you have time, take a look at @garydgregory 's last comment about SDK classes 👍
added new method 'formatDurationWordsWithMs' for format duration:
0 days 0 hours 0 minutes 0 seconds 0 milliseconds
still exists old method 'formatDurationWords' which format as below:
0 days 0 hours 0 minutes 0 seconds