reformat Locks and LocksTest for passing Checkstyle #532
Conversation
Hi. commit apache@c141bc9 broke the Checkstyle, thus making travis-ci cannot pass. thus I made a commit to fix it.
|
I got a build error when update my pull request today. What should I do? |
your build passed, but check style failed. |
Thank you! |
Wait with patience. (embarrassed to admit but recently I put lots of "junk-pr"s which just do some clean-up/typofix but might cause people consume more time than expected in. Sorry about that.) |
|
Hi,
could someone please advise me, what I am doing wring here? Trying to pull
this in:
git clone https://gitbox.apache.org/repos/asf/commons-lang.git
cd commons-lang
git config core.autocrlf true
git remote add github https://github.com/apache/commons-lang.git
git fetch github pull/532:pr/532
git merge pr/532
mvn
....
You have 345 Checkstyle violations.
…On Sat, May 30, 2020 at 4:33 PM XenoAmess ***@***.***> wrote:
Hi.
commit c141bc9
<c141bc9>
broke the Checkstyle, thus making travis-ci cannot pass.
thus I made a commit to fix it.
------------------------------
You can view, comment on, or merge this pull request online at:
#532
Commit Summary
- reformat Locks and LocksTest for passing Checkstyle
File Changes
- *M* src/main/java/org/apache/commons/lang3/Locks.java
<https://github.com/apache/commons-lang/pull/532/files#diff-32fce58470b8035f287da92986131fb4>
(94)
- *M* src/test/java/org/apache/commons/lang3/LocksTest.java
<https://github.com/apache/commons-lang/pull/532/files#diff-b866a8cd59b73583fe87a4636716a626>
(95)
Patch Links:
- https://github.com/apache/commons-lang/pull/532.patch
- https://github.com/apache/commons-lang/pull/532.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#532>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIBUGOQNLTKPXBFG2HAIW3RUEKKNANCNFSM4NOW7JNQ>
.
--
Look, that's why there's rules, understand? So that you think before
you break 'em.
-- (Terry Pratchett, Thief of Time)
|
|
Do this: |
|
Thanks, Gary, that helped.
One more thing, though: I do not feel responsible for this one:
[INFO] There is 1 error reported by Checkstyle 8.32 with src/site/reso
urces/checkstyle/checkstyle.xml ruleset.
[ERROR] target\maven-archiver\pom.properties:[1] (misc) NewlineAtEndOf
File: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
Jochen
…On Sun, May 31, 2020 at 4:54 PM Gary Gregory ***@***.***> wrote:
Do this:
git config core.autocrlf input
git checkout release
git checkout master
mvn checkstyle:check
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
--
Look, that's why there's rules, understand? So that you think before
you break 'em.
-- (Terry Pratchett, Thief of Time)
|
|
@jochenw glad it worked for you. |
Hi.
commit c141bc9 broke the Checkstyle, thus making travis-ci cannot pass.
thus I made a commit to fix it.