Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LANG-1609] - Case-insensitive variants for startsWithAny and endsWithAny #641

Closed
wants to merge 1 commit into from
Closed

[LANG-1609] - Case-insensitive variants for startsWithAny and endsWithAny #641

wants to merge 1 commit into from

Conversation

arturobernalg
Copy link
Member

Add methods to StringUtils class
StringUtils::startsWithAnyIgnoreCase(CharSequence, CharSequence...)
StringUtils::endsWithAnyIgnoreCase(CharSequence, CharSequence...)

@coveralls
Copy link

coveralls commented Nov 9, 2020

Coverage Status

Coverage increased (+0.004%) to 95.016% when pulling f6c0cc9 on arturobernalg:feature/LANG-1609 into 9fa1d73 on apache:master.

@arturobernalg arturobernalg changed the title LANG-1609 - Case-insensitive variants for startsWithAny and endsWithAny [LANG-1609] - Case-insensitive variants for startsWithAny and endsWithAny Nov 9, 2020
@arturobernalg
Copy link
Member Author

Hi @garydgregory
ping here ;)

@XenoAmess
Copy link
Contributor

@garydgregory @arturobernalg I remembered gary had a plan to due with all ignoreCase functions differently, in lang4.
Also, should this function be added directly to commons-text instead of commons-lang?

@garydgregory
Copy link
Member

@garydgregory @arturobernalg I remembered gary had a plan to due with all ignoreCase functions differently, in lang4.
Also, should this function be added directly to commons-text instead of commons-lang?

Good reminder @XenoAmess
I want us to think about what belongs in Lang vs. Text. IMO when we talk about "case", we talk about Text. As opposed to a String which is a wrapper for an array. So I think I'd like to see case operations in Text. Needs more study... I certainly don't want to keep growing StringUtils beyond it's current kitchen sink style.

@arturobernalg
Copy link
Member Author

Hi @garydgregory @XenoAmess
I really didn't know that. How can I know those things?
So, and now? What do I do with the PR?do i need close the PR?

@garydgregory
Copy link
Member

In general, information is spread about on the dev mailing list, PR comments, and JIRA tickets. The dev ML has the most history information I would say but JIRAs and PRs are also important. Remember that this is a volunteer based organization and that we do our best :-)

@nstdio
Copy link
Contributor

nstdio commented Jan 4, 2021

Is this same #630 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants