Updating javadoc for NullPointerException when Validate.notNull() is called #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
changed the title
|
@dvmarcilio Thank you so much. More PRs are welcome. |
garydgregory
added a commit
that referenced
this pull request
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I updated some javadocs that mentioned
IllegalArgumentExceptionwhen an argument isnullinstead ofNullPointerException. Tests were already checking for NPE, so I didn't write any.This PR is similar to #785.
This is because of ba607f5, when lots of calls to
Validate.isTrue(arg != null)(throws IAE) were changed toValidate.notNull(arg)(throws NPE).The same wrong javadocs are also still present for
DateUtilsandFieldUtils.I'll be glad to provide PRs for those if you feel it's needed. However, the diffs there will be much larger.
Thanks!